Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML ACS Endpoint should ignore any unknown parameters #58850

Closed
azasypkin opened this issue Feb 28, 2020 · 3 comments
Closed

SAML ACS Endpoint should ignore any unknown parameters #58850

azasypkin opened this issue Feb 28, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Security/Authentication Platform Security - Authentication Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@azasypkin
Copy link
Member

azasypkin commented Feb 28, 2020

Currently our SAML ACS Endpoint expects only SAMLResponse and RelayState parameters and rejects requests that provide anything else that we don't expect. This may become a problem for IdPs that used to send some additional parameters for whatever reason.

It shouldn't harm if we stop rejecting such requests and just ignore unknown parameters. We could potentially use allowUnknown of schema.object validation scheme we use for the request body, but I don't like that after validation we'll still have these unknown properties in the object that someone can potentially enumerate through. After a conversation with @restrry we think that there is a chance we may add an additional schema.object mode that may allow unknown properties, but would strip them out.

@azasypkin azasypkin added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Security/Authentication Platform Security - Authentication labels Feb 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Feb 28, 2020

After a conversation with @restrry we think that there is a chance we may add an additional schema.object mode that may allow unknown properties, but would strip them out.

I like this idea. Something along the lines of allowUnknown and ignoreUnknown would be pretty helpful I think.

@azasypkin
Copy link
Member Author

Fixed in #69401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Security/Authentication Platform Security - Authentication Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

3 participants