Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use minLength: 1 on string validations in alerting? #60614

Closed
mikecote opened this issue Mar 19, 2020 · 4 comments
Closed

Should we use minLength: 1 on string validations in alerting? #60614

mikecote opened this issue Mar 19, 2020 · 4 comments
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@mikecote
Copy link
Contributor

It was brought up in this PR #60468 (review) that there may be other places within the alerting framework that could benefit from requiring non-empty strings.
@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this issue Mar 19, 2020
Merged
@mikecote mikecote added this to To-Do 7.8 (Ordered by priority) in Make it Action Mar 30, 2020
@pmuellr
Copy link
Member

pmuellr commented Mar 30, 2020

Will need to watch out for some fields - like index action - which for the time field value, accepts an empty string and treats it as null, on the ui side. It might need to be changed on the server, and/or some kind of new validation.

@mikecote mikecote moved this from To-Do (Ordered by priority) to Bugs & Code Debt in Make it Action May 7, 2020
@mikecote mikecote removed this from Bugs & Tech Debt in Make it Action Jan 27, 2021
@mikecote mikecote added this to Bugs & Tech Debt in Kibana Alerting Jan 27, 2021
@YulNaumenko YulNaumenko moved this from Bugs & Tech Debt to Backlog in Kibana Alerting Mar 10, 2021
@YulNaumenko YulNaumenko added the technical debt Improvement of the software architecture and operational architecture label Mar 11, 2021
@gmmorris gmmorris added the Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework label Jul 1, 2021
@gmmorris gmmorris added the loe:medium Medium Level of Effort label Jul 15, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@XavierM XavierM removed this from Backlog in Kibana Alerting Jan 6, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote
Copy link
Contributor Author

mikecote commented May 4, 2023

Could be useful for validating email subject / body messages.

@pmuellr
Copy link
Member

pmuellr commented Jul 10, 2024

This has been opened for a while, and I don't think we've seen a systemic need for this.

@pmuellr pmuellr closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pmuellr @gmmorris @kobelb @mikecote @elasticmachine @YulNaumenko