Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Rainbow palette should use colors from the color service #62219

Closed
wylieconlon opened this issue Apr 1, 2020 · 3 comments · Fixed by #62241
Closed

[TSVB] Rainbow palette should use colors from the color service #62219

wylieconlon opened this issue Apr 1, 2020 · 3 comments · Fixed by #62241
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Apr 1, 2020

When using the TSVB rainbow palette, the colors are assigned by position using a custom list of ~20 colors that isn't used anywhere else in Kibana. Instead, the color mapping service used by Visualize should be used in this case.

The goal of this change is to create a consistent dashboard experience, creating consistency. You can see the inconsistency when comparing two identical visualizations side-by-side, where one is using Visualize and the other is using TSVB:

Screenshot 2020-04-01 14 56 42

Unlike making a change to the default palette in visualize, TSVB doesn't currently support overriding any part of the rainbow palette. This should make it a minor change for users.

@wylieconlon wylieconlon added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor Author

Looks like this is not as easy technically as I thought: TSVB is handling colors on the server-side, while the color service used in dashboards is done client-side.

@wylieconlon
Copy link
Contributor Author

An example of what we are targeting is below:

Screenshot 2020-04-01 16 46 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants