Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event log to store namespace per saved object #62672

Closed
mikecote opened this issue Apr 6, 2020 · 2 comments · Fixed by #62974
Closed

Event log to store namespace per saved object #62672

mikecote opened this issue Apr 6, 2020 · 2 comments · Fixed by #62974
Assignees
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Apr 6, 2020

In preparation for #27004, each saved object within kibana.saved_objects should have their own namespace attribute. With this change kibana.namespace can also be removed.

Current saved object reference mappings (to be enhanced):

"saved_objects": {
"properties": {
"store": {
"type": "keyword",
"ignore_above": 1024
},
"id": {
"type": "keyword",
"ignore_above": 1024
},
"type": {
"type": "keyword",
"ignore_above": 1024
}
},

Current namespace mapping (to be removed):

"namespace": {
"type": "keyword",
"ignore_above": 1024
},

Note, that we have also decided to remove the store field from the saved object references for now - it was intended to allow saved objects in separate indices (like task manager documents) to be referenced. We've decided to defer that for now, we can add it back later.

The existing search API will need to be updated.

I am kind of wondering if there's an aspect of the kibana.namespace that we want to keep - today I don't think it would ever be useful, except maybe for the case of logging action execution via http requests - the namespace value would be the namespace in the URI. I think we can delete it today, and add it back later if we need to.

@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote added this to To-Do 7.8 (Ordered by priority) in Make it Action Apr 6, 2020
@gmmorris gmmorris moved this from To-Do 7.8 (Ordered by priority) to In Progress in Make it Action Apr 8, 2020
@gmmorris gmmorris self-assigned this Apr 8, 2020
@pmuellr
Copy link
Member

pmuellr commented Apr 8, 2020

This is probably a good time to check in with folks looking at the Kibana Platform logging meta issue to show them our kibana top-level property, and saved object references in particular. It would be nice to align on these ...

@gmmorris gmmorris moved this from In Progress to In Review in Make it Action Apr 9, 2020
@mikecote mikecote moved this from In Review to Done (Ordered by most recent) in Make it Action Apr 14, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Make it Action
  
Done (Ordered by most recent)
Development

Successfully merging a pull request may close this issue.

5 participants