Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Most alerting api integration & functional tests do not work on cloud #63898

Open
mikecote opened this issue Apr 17, 2020 · 3 comments
Labels
estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage

Comments

@mikecote
Copy link
Contributor

When running the alerting functional and api integration tests on cloud, it doesn't use any configuration changes made within config.ts. This means it doesn't allow to create custom plugins, setup pre-configured connectors, etc.

I'm opening this issue to come up with a plan / fix so we can isolate tests that depend on custom configuration from normal tests. There's some refactoring I'm sure can get a good amount of tests working on cloud now that we have built in alert types and build in action types.

@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Apr 17, 2020

Hopefully there's some option available to test our config properties that we've whitelisted. I think that's probably the host whitelisting for actions, and actionType enablement.

It probably makes sense to allow preconfigured actions in the cloud (will need to be whitelisted), but I think only if we have a way to access the action secrets in the keystore. Not sure how that's done today - does Kibana config do that automagically somehow? Cloud does provide access to the elastic keystore - to add new key names / secrets, and see a list of the key names.

@mikecote
Copy link
Contributor Author

This may be a pre-requisite: #58244.

@mikecote mikecote added this to Bugs & Code Debt in Make it Action Apr 27, 2020
@mikecote mikecote removed this from Bugs & Tech Debt in Make it Action Jan 27, 2021
@mikecote mikecote added this to Bugs & Tech Debt in Kibana Alerting Jan 27, 2021
@YulNaumenko YulNaumenko moved this from Bugs & Tech Debt to Backlog in Kibana Alerting Mar 10, 2021
@YulNaumenko YulNaumenko added the technical debt Improvement of the software architecture and operational architecture label Mar 11, 2021
@gmmorris gmmorris added the loe:needs-research This issue requires some research before it can be worked on or estimated label Jul 15, 2021
@YulNaumenko YulNaumenko added code coverage Issues & PRs about code coverage test-coverage issues & PRs for improving code test coverage and removed code coverage Issues & PRs about code coverage labels Aug 13, 2021
@gmmorris gmmorris added the estimate:needs-research Estimated as too large and requires research to break down into workable issues label Aug 18, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@XavierM XavierM removed this from Backlog in Kibana Alerting Jan 6, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@EricDavisX EricDavisX changed the title Most alerting api integration & functional tests do not work on cloud [ResponseOps] Most alerting api integration & functional tests do not work on cloud Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture test-coverage issues & PRs for improving code test coverage
Projects
No open projects
Development

No branches or pull requests

6 participants