Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Features plugin contract names user friendly #65999

Open
mshustov opened this issue May 11, 2020 · 1 comment
Open

Make Features plugin contract names user friendly #65999

mshustov opened this issue May 11, 2020 · 1 comment
Labels
chore enhancement New value added to drive a business result Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
kibana-core [DEPRECATED]

Comments

@mshustov
Copy link
Contributor

Setup and start contracts are exposed as PluginSetupContract & PluginStartContract respectively. Consumers have to rename them locally to avoid a name collision

kibana/x-pack/plugins/canvas/server/plugin.ts

Line 12 in 25cedbe

import { PluginSetupContract as FeaturesPluginSetup } from '../../features/server';

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform enhancement New value added to drive a business result labels May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov self-assigned this May 11, 2020
@joshdover joshdover moved this from 7.9 to In Progress in kibana-core [DEPRECATED] May 12, 2020
@mshustov mshustov moved this from In Progress to 7.9 in kibana-core [DEPRECATED] May 13, 2020
@joshdover joshdover moved this from 7.9 to 7.10 - Tentative in kibana-core [DEPRECATED] Jul 15, 2020
@joshdover joshdover moved this from 7.10 to 7.11 - Tenatitive in kibana-core [DEPRECATED] Sep 8, 2020
@joshdover joshdover moved this from 7.11 - Tenatitive to 7.12 - Tentative in kibana-core [DEPRECATED] Sep 10, 2020
@joshdover joshdover moved this from 7.12 - Tentative to Tech Debt Backlog in kibana-core [DEPRECATED] Dec 2, 2020
@mshustov mshustov removed their assignment May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore enhancement New value added to drive a business result Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
kibana-core [DEPRECATED]
Tech Debt Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshdover @mshustov @elasticmachine