You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following an SDH issue, I started adding an error indicator to FilterBar to appear when a filter uses a missing IndexPattern.
This new ability, uncovered an underlying issue that I want to discuss here.
SearchBar Index Patterns
At the moment, we're giving TopNavMenu a list of IndexPatterns. This list is a subset of all index patterns. We use this list, rather than the full index pattern list, to:
Restrict autocomplete in QueryInputString component, to fetch relevant suggestions
Check the existence of a filter's index pattern and fields.
Show the Index Patterns drop down in FilterEditor in case of any errors.
Saved Queries
When you load a SavedQuery it may apply filters that reference an index pattern that is not passed into the filter bar. Therefore they now appear as errors.
I think we need to save the "Error" indication for deleted index patterns or fields, and filters such as the one in the image above need to have a clear warning.
So the logic would be:
If the filter's index pattern is in the list passed in by the application - It's OK
If the filter's index pattern is not in the list passed in by the application, but it does exist in kibana - Show a warning
If the filter's index pattern does not exist in kibana - show an error.
The text was updated successfully, but these errors were encountered:
Following an SDH issue, I started adding an error indicator to
FilterBar
to appear when a filter uses a missingIndexPattern
.This new ability, uncovered an underlying issue that I want to discuss here.
SearchBar Index Patterns
At the moment, we're giving
TopNavMenu
a list ofIndexPatterns
. This list is a subset of all index patterns. We use this list, rather than the full index pattern list, to:QueryInputString
component, to fetch relevant suggestionsIndex Patterns
drop down inFilterEditor
in case of any errors.Saved Queries
When you load a
SavedQuery
it may apply filters that reference an index pattern that is not passed into the filter bar. Therefore they now appear as errors.I think we need to save the "Error" indication for deleted index patterns or fields, and filters such as the one in the image above need to have a clear warning.
So the logic would be:
The text was updated successfully, but these errors were encountered: