Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and warning indicators for filters in FilterBar #67177

Closed
lizozom opened this issue May 21, 2020 · 1 comment
Closed

Error and warning indicators for filters in FilterBar #67177

lizozom opened this issue May 21, 2020 · 1 comment
Assignees

Comments

@lizozom
Copy link
Contributor

lizozom commented May 21, 2020

Following an SDH issue, I started adding an error indicator to FilterBar to appear when a filter uses a missing IndexPattern.

This new ability, uncovered an underlying issue that I want to discuss here.

SearchBar Index Patterns

At the moment, we're giving TopNavMenu a list of IndexPatterns. This list is a subset of all index patterns. We use this list, rather than the full index pattern list, to:

  • Restrict autocomplete in QueryInputString component, to fetch relevant suggestions
  • Check the existence of a filter's index pattern and fields.
  • Show the Index Patterns drop down in FilterEditor in case of any errors.

Saved Queries

When you load a SavedQuery it may apply filters that reference an index pattern that is not passed into the filter bar. Therefore they now appear as errors.

image

I think we need to save the "Error" indication for deleted index patterns or fields, and filters such as the one in the image above need to have a clear warning.

So the logic would be:

  • If the filter's index pattern is in the list passed in by the application - It's OK
  • If the filter's index pattern is not in the list passed in by the application, but it does exist in kibana - Show a warning
  • If the filter's index pattern does not exist in kibana - show an error.
@lizozom lizozom self-assigned this May 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine kibanamachine added this to To triage in kibana-app-arch May 21, 2020
@lizozom lizozom changed the title Error indicators and index patterns in FilterBar Error and warning indicators for filters in FilterBar May 21, 2020
@lizozom lizozom closed this as completed Jun 3, 2020
kibana-app-arch automation moved this from To triage to Done in current release Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
kibana-app-arch
  
Done in current release
Development

No branches or pull requests

2 participants