Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable Index Templates UI - Feedback #68056

Open
sebelga opened this issue Jun 3, 2020 · 4 comments
Open

Composable Index Templates UI - Feedback #68056

sebelga opened this issue Jun 3, 2020 · 4 comments
Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sebelga
Copy link
Contributor

sebelga commented Jun 3, 2020

This issue will serve as the place to track concerns and feedback during development of composable templates. These concerns might evolve and not exist anymore as we iterate on the feature.

To avoid blocking PRs on things we are not yet certain (we might need to see the feature as a whole to decide on a copy text "term"), I suggest to add a comment for each feedback and revisit them on each iteration of the feature.

I suggest that we use 3 statuses for feedbacks: PENDING | ADDRESSED | NO_MORE_RELEVANT

@sebelga
Copy link
Contributor Author

sebelga commented Jun 3, 2020

PR: #67282
Author: @alisonelizabeth (#67282 (review))
Status: PENDING

Since we have two tables now, what do you think about changing the default page size to 10 instead of 20? I didn't test it, but I imagine if you had 20 composable templates, you would have to scroll to see the legacy templates.

@sebelga : As discussed in the zoom presentation for the creation flow, we might still reconsider to have a single table for the index templates and have below the table of components template. Let's wait to see if this option would work before making the change you suggest.

@sebelga
Copy link
Contributor Author

sebelga commented Jun 3, 2020

PR: #67282
Author: @alisonelizabeth (#67282 (review))
Status: PENDING

It felt a little weird to me having one filter to view composable templates and system templates, since the system filter applies to both tables, whereas selecting composable hides or removes the one table. I'd be interested to see if design has any feedback on this though.

@sebelga : For the same reason as above, if we end up having a single table to display the index template this concern would not exist. Let's wait for now until that decision is made.

@sebelga
Copy link
Contributor Author

sebelga commented Jun 3, 2020

PR: #67282
Author: @alisonelizabeth (#67282 (comment))
Status: PENDING

[nit] Is "Overrides" the right term to use here? As we are just checking whether mappings/settings/aliases exist, it may or may not be an override (if I understand correctly).

@sebelga : Good point. Let's wait on the stakeholder review. My thought is that we might want to call it "Settings" and then those badges indicate if there are mappings or not (looking both in the component templates and the possible "overrides")

@cjcenizal cjcenizal added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants