Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Field Formatters not working for multiple layers #68260

Closed
LucaWintergerst opened this issue Jun 4, 2020 · 2 comments · Fixed by #69911
Closed

[Lens] Field Formatters not working for multiple layers #68260

LucaWintergerst opened this issue Jun 4, 2020 · 2 comments · Fixed by #69911
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@LucaWintergerst
Copy link
Contributor

Kibana version: 7.7.0

Elasticsearch version: 7.7.0

Server OS version: Elastic Cloud

Browser version: Chrome 83

Browser OS version: MacOs

Original install method (e.g. download page, yum, from source, etc.): Elastic Cloud

Describe the bug: Field Formatters only work for a single metric in Kibana, not for multiple layers

Steps to reproduce:

  1. visualize a field with a bytes field formatter => looks good
  2. add second layer with a field, also using a field formatter of type bytes => no longer displaying Bytes
    Expected behavior:

Screenshots (if relevant):
Screenshot 2020-06-04 at 16 16 59
Screenshot 2020-06-04 at 16 16 01

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine kibanamachine added this to Long-term goals in Lens Jun 4, 2020
@flash1293 flash1293 moved this from Long-term goals to Priority bugs in Lens Jun 4, 2020
@flash1293
Copy link
Contributor

This is happening on purpose right now because there is just a single axis and if there are multiple field formatters, it's not clear which one to apply:

// use default number formatter for y axis and use formatting hint if there is just a single y column

This behavior is safe (we won't ever display a dollar amount on a byte axis) but it's probably not the best one for cases like the one in the example with multiple metrics in different layers which actually use the same formatter.

The least we can do is to check whether the formatters of the different metric columns are identical. For other cases we should implement #53663 which would just split into two different axes if the formatters are different.

@flash1293 flash1293 moved this from Priority bugs to Minor bugs in Lens Jun 8, 2020
Lens automation moved this from Minor bugs to Done Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants