Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of CSP check #71060

Closed
mshustov opened this issue Jul 8, 2020 · 4 comments
Closed

Get rid of CSP check #71060

mshustov opened this issue Jul 8, 2020 · 4 comments
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jul 8, 2020

Kibana doesn't support IE11 from the v7.9 release. We can remove the browser supporting CSP check

{`
// Since this is an unsafe inline script, this code will not run
// in browsers that support content security policy(CSP). This is
// intentional as we check for the existence of __kbnCspNotEnforced__ in
// bootstrap.
window.__kbnCspNotEnforced__ = true;
`}
as all other browsers from Supported Browsers matrix implement CSP https://www.elastic.co/support/matrix#matrix_browsers

Note: Kibana might continue working accidentally as long as IE11 listed in compilation targets. We should wait until it's removed from the list #42279

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@epixa
Copy link
Contributor

epixa commented Jul 8, 2020

I don’t recommend removing this check. An XSS vulnerability doesn’t just put that user at risk, it can give an attacker access (directly or indirectly) to kibana itself. So Kibana may be exploited if any user is impacted by XSS.

This check ensures people with broken CSP support are unable to load Kibana at all. That does include IE11, but it also includes older versions of existing browsers, or any future version of a browser that regresses in its CSP support, like Microsoft Edge did at some point.

@epixa
Copy link
Contributor

epixa commented Jul 8, 2020

@elastic/kibana-security fyi

@legrego
Copy link
Member

legrego commented Jul 8, 2020

Thanks for the ping @epixa. I agree with Court here: in addition to a browser regression, we've also seen enterprises configure group policies which instruct otherwise compliant browsers to use a different (often incompatible) CSP, ignoring the policy that Kibana itself sends.

@mshustov mshustov closed this as completed Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Development

No branches or pull requests

4 participants