Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails sent from Kibana Alerting to have a footer with a link back to the alert details #71243

Closed
mikecote opened this issue Jul 9, 2020 · 4 comments · Fixed by #84371
Closed
Assignees
Labels
enhancement New value added to drive a business result Feature:Actions Feature:Alerting R&D Research and development ticket (not meant to produce code, but to make a decision) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Jul 9, 2020

As a split from the original issue #49392. It would be nice for all the emails that are generated from Kibana alerts to have a footer with a link back to the alert details page. This would remove the requirement for the user to manually enter a URL within their message.

The approach like GitHub email notifications is what I originally had in mind. A "View in Kibana" link at the bottom or something along those lines.

NOTE:
This will depend on #45815 but work can be started in parallel.

@mikecote mikecote added Feature:Alerting Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jul 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor Author

mikecote commented Jul 9, 2020

This may depend on something like #45815 to work for alerts created via the HTTP APIs, pre-configured alerts, etc.

@mikecote mikecote added this to Short Term in Make it Action Jul 15, 2020
@mikecote mikecote changed the title Emails sent from Kibana Alerting to have a footer with a link back to the alter details Emails sent from Kibana Alerting to have a footer with a link back to the alert details Jul 17, 2020
@mikecote mikecote moved this from Short Term to 7.11 - Tentative in Make it Action Aug 6, 2020
@mikecote mikecote added the enhancement New value added to drive a business result label Aug 19, 2020
@mikecote mikecote moved this from 7.11 - Tentative to 7.12 - Tentative in Make it Action Aug 26, 2020
@mikecote mikecote added the R&D Research and development ticket (not meant to produce code, but to make a decision) label Sep 9, 2020
@mikecote mikecote moved this from 7.12 - Tentative to 7.11 Post GA - Tentative in Make it Action Oct 22, 2020
@mikecote mikecote moved this from 7.11 - Post GA to To-Do (Ordered by priority) in Make it Action Oct 30, 2020
@mikecote
Copy link
Contributor Author

cc @arisonl

@pmuellr
Copy link
Member

pmuellr commented Nov 12, 2020

Thinking about how this should work.

Wondering if the thought here helps: #66095 (comment)

Maybe yes? So the default action message we calculate could return an additional bit at the bottom with the relevant link in it?

Longer-term, I keep in mind the multi-step action story of "create GH issue" -> "send email", where the email should have a link to both the alert details AND the GH issue, so I think this gets complex.

Maybe we need to have top-level support for something like a links action param, which would be an array, and we'd pre-fill one for alerts pointing to the alert details, other alerts (and previous actions) could add additional links to their solution pages or whatever. Actions would then be responsible for rendering these as appropriate, which would be appending to the bottom of the message, typically. The links elements would need to have some message text to render beside the link (and perhaps some anchor text, eh, that will get complicated) as well as the link itself.

Eg,

actionParams.links.push({ message: 'alert details:', link: 'http://example.com' })
scheduleAction(... actionParams ...)

I think today, all our actions would be fine if they just rendered this as alert details: http://example.com (ie, plain text, slack markdown, email markdown), but if we end up having an action that requires html formatting, it would need to be alert details: <a href='http://example.com'>http://example.com</a> - seems like we need to consider such things - allow the action to do the final formatting.

Not directly related, but I believe we'll also want a message "prefix" and "suffix" as well, for folks who need to put some kind of disclaimer on all their notifications. This seems more "global" than "alert-specific", but something to keep in mind ...

@gmmorris gmmorris moved this from To-Do (Ordered by priority) to In Progress in Make it Action Nov 20, 2020
@gmmorris gmmorris assigned gmmorris and unassigned gmmorris Nov 20, 2020
@gmmorris gmmorris moved this from In Progress to To-Do (Ordered by priority) in Make it Action Nov 20, 2020
@mikecote mikecote removed the blocked label Nov 23, 2020
@mikecote mikecote moved this from To-Do (Ordered by priority) to In Progress in Make it Action Nov 25, 2020
@mikecote mikecote self-assigned this Nov 25, 2020
@mikecote mikecote moved this from In Progress to In Review in Make it Action Dec 14, 2020
Make it Action automation moved this from In Review to Done (Ordered by most recent) Dec 15, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Actions Feature:Alerting R&D Research and development ticket (not meant to produce code, but to make a decision) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Make it Action
  
Done (Ordered by most recent)
5 participants