Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Number of environments displayed in the selector should be increased and made configurable #71719

Closed
ogupte opened this issue Jul 14, 2020 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@ogupte
Copy link
Contributor

ogupte commented Jul 14, 2020

Currently the number of environments loaded in the environment filter is limited to the default size of the terms agg when we query for them (https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/server/lib/ui_filters/get_environments.ts#L49). Ideally, we want to load all environments in the selector. One workaround now is to use the query bar service.environment : "test" but only if the target environment is known ahead of time.

One solution for this is to set a size on the terms agg that is sufficiently large for most use cases. Also we could make the size configurable. if we changed it to a composite aggregation, we can be sure to return all unique environments, but may have to deal with the complexity of paging results.

@ogupte ogupte added [zube]: Inbox Team:APM All issues that need APM UI Team support labels Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte changed the title [APM] Environment filter should display all environments [APM] Environment selector should display all environments Jul 14, 2020
@sorenlouv sorenlouv added [zube]: Backlog bug Fixes for quality problems that affect the customer experience and removed [zube]: Inbox labels Jul 15, 2020
@sorenlouv sorenlouv changed the title [APM] Environment selector should display all environments [APM] Number of environments displayed in the selector should be configurable Jul 15, 2020
@sorenlouv sorenlouv changed the title [APM] Number of environments displayed in the selector should be configurable [APM] Number of environments displayed in the selector should be increased and made configurable Oct 16, 2020
@sorenlouv
Copy link
Member

Closed in #82090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

4 participants