Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderComplete helper (visualize_embeddable) #71848

Closed
2 tasks done
streamich opened this issue Jul 15, 2020 · 0 comments · Fixed by #74504
Closed
2 tasks done

RenderComplete helper (visualize_embeddable) #71848

streamich opened this issue Jul 15, 2020 · 0 comments · Fixed by #74504
Labels
Feature:Embedding Embedding content via iFrame
Projects
kibana-app-arch

Comments

@streamich
Copy link
Contributor

streamich commented Jul 15, 2020 •
edited

  • In visualize_embeddable extract render-complete logic into a separate module, say RednerCompleteDispatcher.
  • Use RednerCompleteDispatcher module in visualize_embeddable Embeddable class.
  • Create a React wrapper component for RenderComplete for easy usage in React code, possibly use it in visualize_embeddable.

Part of #71857
@streamich streamich added the Feature:Embedding Embedding content via iFrame label Jul 15, 2020
@streamich streamich added this to To triage in kibana-app-arch via automation Jul 15, 2020
This was referenced Jul 15, 2020
Closed
Closed
@streamich streamich mentioned this issue Aug 13, 2020
Merged
kibana-app-arch automation moved this from To triage to Done in current release Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame
Projects
kibana-app-arch
  
Done in current release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modularize render complete
1 participant
@streamich