Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workplace Search and App Search are not updating browser title #73925

Closed
hendry-lim opened this issue Jul 31, 2020 · 3 comments · Fixed by #74392
Closed

Workplace Search and App Search are not updating browser title #73925

hendry-lim opened this issue Jul 31, 2020 · 3 comments · Fixed by #74392
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:EnterpriseSearch

Comments

@hendry-lim
Copy link

hendry-lim commented Jul 31, 2020

Kibana version: 7.9.0-SNAPSHOT

Elasticsearch version: 7.9.0-SNAPSHOT

Original install method (e.g. download page, yum, from source, etc.): Docker

Describe the bug:
Browser/page title was not updated if navigating to App Search and Workplace Search.

Steps to reproduce:

  1. In Kibana, go to App Search or Workplace Search

Expected behavior:
Browser/page title should probably be updated to something like the following (based on Observability Overview):

  • Setup Guide | App Search | Enterprise Search for App Search
  • Setup Guide | Workplace Search | Enterprise Search for Workplace Search

Screenshots (if relevant):
image

@hendry-lim hendry-lim changed the title Workplace Search and App Search do not update browser title Workplace Search and App Search are not updating browser title Jul 31, 2020
@kindsun kindsun added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana Team:AppArch labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine kibanamachine added this to To triage in kibana-app-arch Jul 31, 2020
@Dosant Dosant removed Feature:Search Querying infrastructure in Kibana Team:AppArch labels Aug 1, 2020
@Dosant Dosant removed this from To triage in kibana-app-arch Aug 1, 2020
@cee-chen cee-chen self-assigned this Aug 5, 2020
@cee-chen
Copy link
Member

cee-chen commented Aug 5, 2020

Thanks for finding this @hendry-lim! I should have a fix for this shortly. The fix will probably be released for 7.10, not 7.9, since other plugins such as Machine Learning also don't appear to set document titles for their apps. This is a great catch though, super appreciate your eagle eye!

@hendry-lim
Copy link
Author

hendry-lim commented Aug 5, 2020

@constancecchen no problem. There are number of places where the doc title is not set. Another place worth mentioning will be the Management area, but I believe a separate issue has been raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:EnterpriseSearch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants