Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Make "auto-apply" behavior configurable #74490

Closed
flash1293 opened this issue Aug 6, 2020 · 4 comments · Fixed by #125158
Closed

[Lens] Make "auto-apply" behavior configurable #74490

flash1293 opened this issue Aug 6, 2020 · 4 comments · Fixed by #125158
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@flash1293
Copy link
Contributor

Build a switch to auto-run or not. It should be as global as possible and resemble the behavior of Visualize where it shows a big "apply" button which runs all changes

@flash1293 flash1293 created this issue from a note in Lens (Long-term goals) Aug 6, 2020
@flash1293 flash1293 added enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

flash1293 commented Jan 26, 2022

My proposal for the style of this - we already have an extremely similar UI for vega, I propose we simply re-use it for Lens as well:

Default view, auto apply on:
Screenshot 2022-01-26 at 11 07 22 copy

Auto apply turned off, no pending changes:
Screenshot 2022-01-26 at 11 07 22

Auto apply turned off, pending changes:
Screenshot 2022-01-26 at 11 07 22 copy 2

What do you think @MichaelMarcialis ? Can we start with this?

@rayafratkina
Copy link
Contributor

It took me a full minute to find these buttons...
I would propose placing the switch much more prominently - if I am used to seeing stuff change immediately, I will not notice/forget about these and it will be really jarring.

@MichaelMarcialis
Copy link
Contributor

Thanks, @flash1293. This is an interesting concept. I like that it has some consistency with another visualization editor app that users may be familiar with. That said, I do have concerns about this suggested placement of the auto-apply UI within Lens, both from a discoverability and hierarchical perspective. Placing these controls at the bottom of layer section will likely lead users into thinking that these controls only involve changes made to the layer section (when in fact, these controls will involve changes made to other areas as well, such as the workspace toolbar options).

When we first began discussing this feature, my first instinct was to place such controls to appear more global to the app, in the top white bar (adjacent to inspect, save, etc). I'd probably also desire to consolidate or minimize certain aspects of the Vega-like controls (such as moving the keyboard shortcut tooltip to the update button rather than an extraneous icon, reducing the size/prominence of the discard and auto-apply on/off toggle, etc.)

I would love to take a design pass at this myself, but I'm currently out-of-pocket with other priorities until the mid-8.2 development cycle. Is the team in a position to be able to wait until that point, or do you need to begin engineering sooner? If sooner, let me know and I can chat with my manager (@ryankeairns) to see if there's some priority shuffling we can do.

@drewdaemon drewdaemon self-assigned this Feb 4, 2022
@flash1293 flash1293 moved this from Long-term goals to 8.2 in Lens Feb 9, 2022
@MichaelMarcialis MichaelMarcialis self-assigned this Feb 23, 2022
Lens automation moved this from 8.2 to Done Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants