Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update/unskip event viewer action tests to match new format #75934

Closed
dplumlee opened this issue Aug 25, 2020 · 3 comments
Closed

[Security Solution] Update/unskip event viewer action tests to match new format #75934

dplumlee opened this issue Aug 25, 2020 · 3 comments
Assignees
@dplumlee
Labels
enhancement New value added to drive a business result Team:Endpoint Response Endpoint Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.11.0

Comments

@dplumlee
Copy link
Contributor

Currently the tests in the default_config file are being skipped and commented out. Once this pr (#73228) has been merged, those tests will be antiquated and will need to be moved/updated to match the refactored code and logic

In addition to all current tests being updated, logic for this pr (#75802) will also need to be added
@dplumlee dplumlee added enhancement New value added to drive a business result Team:SIEM Team:Endpoint Response Endpoint Response Team labels Aug 25, 2020
@dplumlee dplumlee self-assigned this Aug 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-response (Team:Endpoint Response)

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@dplumlee dplumlee mentioned this issue Aug 25, 2020
Merged
2 tasks
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
@dplumlee
Copy link
Contributor Author

Closing this with the addition of new code that negates the need for testing #75802, specifically #84006 that enables ML rule exceptions and #85103 that enables Threshold rule exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dplumlee dplumlee

Labels
enhancement New value added to drive a business result Team:Endpoint Response Endpoint Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.11.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peluja1012 @MindyRS @elasticmachine @dplumlee