[Lens] Pass the uiSettings default language to filters aggregation

[mbondyra]

Describe the feature:
Can be done after merging #75635
Right now we use 'kuery' as a default language in filters aggregation, but in the future we want this setting to come from uiSettings. The implementation details can be found below (by Joe):

It looks like there are three cases where the default query is required: When adding a new filter using the add button in the UI (which has access to data), when initializing an empty filters array (in buildColumn) and when writing the esaggs config. The one in buildColumn could be omitted because it will be caught by the logic in toEsAggsConfig and in the UI anyway.

To solve it cleanly we could extend toEsAggsConfig to also pass in data. This is a change scoped in the index pattern datasource. To do so,

kibana/x-pack/plugins/lens/public/indexpattern_datasource/to_expression.ts

Line 129 in ddf99b6

export function toExpression(state: IndexPatternPrivateState, layerId: string) {

has to be replaced by a generator function to pass in the reference and keep it in a function closure:

export function getToExpression(data: DataStart) {
 return function toExpression(state: IndexPatternPrivateState, layerId: string) {
  if (state.layers[layerId]) {
    return getExpressionForLayer(
      state.indexPatterns[state.layers[layerId].indexPatternId],
      state.layers[layerId].columns,
      state.layers[layerId].columnOrder,
      data
    );
  }

  return null;
}
}

Then it can be passed through like this:

kibana/x-pack/plugins/lens/public/indexpattern_datasource/indexpattern.tsx

Line 193 in e82e536

toExpression,

kibana/x-pack/plugins/lens/public/indexpattern_datasource/to_expression.ts

Line 129 in ddf99b6

export function toExpression(state: IndexPatternPrivateState, layerId: string) {

kibana/x-pack/plugins/lens/public/indexpattern_datasource/to_expression.ts

Line 24 in ddf99b6

return operationDefinitionMap[column.operationType].toEsAggsConfig(

kibana/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/filters/filters.tsx

Line 144 in fdbf1ae

toEsAggsConfig: (column, columnId, indexPattern) => {

kibana/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/filters/filters.tsx

Line 154 in fdbf1ae

filters: validFilters?.length > 0 ? validFilters : [getDefaultFilter()],

For buildColumn it's pretty similar - we call it in the dimension panel and popover editor (which have access to data already, so that's easy) and in suggestions. For suggestions, we would need to do the same thing as described above for toEsAggsConfig.

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[PavithraCP]

Hello, I'm a new contributor to kibana. I'm interested in picking this up, is this available?

[flash1293]

Hi @PavithraCP

First, thanks for looking into contributing to Kibana - contributors are always welcome 💚

This issue is indeed up for grabs, but a word of warning - you will have to make changes in quite some places. So while not terribly complicated, this issue can become a bit larger. If you want to start with something with something smaller within Lens, I can recommend #72243 - that shouldn't require more than a couple lines.

If you have interest working on one of those issues, just drop a note, and we can assign you to it. If you will drop it again, please make sure to leave another note, so we can unassign you from that issue again.

[PavithraCP]

Thanks @flash1293 , as per your suggestion I'll start with #72243, I've dropped a note there too :)

[ghudgins]

closing this for lens - KQL is the default and hasn't honored this setting and we haven't received any requests for it. can revisit if something changes later