Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Find and implement generic solution to UI performance #77321

Closed
flash1293 opened this issue Sep 14, 2020 · 2 comments
Closed

[Lens] Find and implement generic solution to UI performance #77321

flash1293 opened this issue Sep 14, 2020 · 2 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects

Comments

@flash1293
Copy link
Contributor

Due to the way Lens is structured updating the state can lead to frame drops while using the UI (e.g. typing in free text fields).

Currently this is fixed by debouncing the state update using the same patterns in multiple places, leading to very similar code in different places:

  • x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/filters/filter_popover.tsx
  • x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/popover_editor.tsx
  • x-pack/plugins/lens/public/pie_visualization/toolbar.tsx

One option to clean this up is to refactor the general "debounced state updater component" and use it in all places. However, maybe it's possible to improve performance by changing the scheme to apply state updates at the top level.

@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added this to Long-term goals in Lens via automation Sep 14, 2020
@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Sep 6, 2023
@stratoula
Copy link
Contributor

Closing as duplicate of #175485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Lens
  
Long-term goals
Development

No branches or pull requests

3 participants