Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] Improve the display logic for the default state of navigational search #78771

Open
ryankeairns opened this issue Sep 29, 2020 · 2 comments
Labels
Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 29, 2020

Related to #75040

While the critically of this issue is low until we have additional providers, the 'display apps only when the term is empty' logic that is in the search bar should be cleaned up. It's also worth noting that this is dependent upon #75040 , wherein we'll determine whether or not to change the default state design altogether, possibly moving away from the initial app list.

Ideally, we would just not be performing a GS search and, instead, retrieving the full app list from core's application.applications$ API. That would avoid unnecessary calls to the backend, and avoid having to increase the max result constant to a value that is too high for other providers. Also, the GS API should just not perform any call to the providers when the term is empty.

Originally posted by @pgayvallet in #78741 (comment)

@ryankeairns ryankeairns added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@ryankeairns ryankeairns added this to Backlog in Navigational Search Oct 6, 2020
@pgayvallet pgayvallet added Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
Development

No branches or pull requests

3 participants