We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Kibana and Firefox throw fatal error when button with tooltip has a click handler with a confirm dialog.
Steps to reproduce - add button with a tooltip:
<button ng-click="myDeleteFunction()" tooltip="Delete widget">Delete</button>
.. and a function handler
$scope.myDeleteFunction = function () { if (confirm('Delete this?')) { console.log('Deleted'); } };
tested on OSX 10.11.5 - does not happen on Chrome and seems related to this angular issue
The text was updated successfully, but these errors were encountered:
The solution to this is to use the safeConfirm service rather than directly using window.confirm: https://github.com/elastic/kibana/blob/master/src/ui/public/safe_confirm/safe_confirm.js
safeConfirm
window.confirm
Sorry, something went wrong.
@markharwood Are you experiencing this in currently committed code?
Yes, the graph "new" menu button has this behaviour but I opened a general issue because it looked like it may impact other areas.
The solution to this is to use the safeConfirm
I'll use that and close this issue, thanks
No branches or pull requests
Latest Kibana and Firefox throw fatal error when button with tooltip has a click handler with a confirm dialog.
Steps to reproduce - add button with a tooltip:
.. and a function handler
tested on OSX 10.11.5 - does not happen on Chrome and seems related to this angular issue
The text was updated successfully, but these errors were encountered: