Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox bug(tooltip): $apply already in progress #8144

Closed
markharwood opened this issue Sep 1, 2016 · 3 comments
Closed

Firefox bug(tooltip): $apply already in progress #8144

markharwood opened this issue Sep 1, 2016 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@markharwood
Copy link
Contributor

Latest Kibana and Firefox throw fatal error when button with tooltip has a click handler with a confirm dialog.

kibana-2

Steps to reproduce - add button with a tooltip:

<button ng-click="myDeleteFunction()" tooltip="Delete widget">Delete</button>

.. and a function handler

$scope.myDeleteFunction = function () {
    if (confirm('Delete this?')) {
      console.log('Deleted');
    }
};

tested on OSX 10.11.5 - does not happen on Chrome and seems related to this angular issue

@markharwood markharwood added the bug Fixes for quality problems that affect the customer experience label Sep 1, 2016
@epixa
Copy link
Contributor

epixa commented Sep 1, 2016

The solution to this is to use the safeConfirm service rather than directly using window.confirm: https://github.com/elastic/kibana/blob/master/src/ui/public/safe_confirm/safe_confirm.js

@epixa
Copy link
Contributor

epixa commented Sep 1, 2016

@markharwood Are you experiencing this in currently committed code?

@markharwood
Copy link
Contributor Author

Yes, the graph "new" menu button has this behaviour but I opened a general issue because it looked like it may impact other areas.

The solution to this is to use the safeConfirm

I'll use that and close this issue, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

2 participants