Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search.esaggs] Move 'other' bucket & inspector integrations to SearchSouce. #83652

Closed
Tracked by #60126 ...
lukeelmers opened this issue Nov 18, 2020 · 1 comment · Fixed by #96241
Closed
Tracked by #60126 ...
Assignees
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Search Querying infrastructure in Kibana technical debt Improvement of the software architecture and operational architecture v7.13.0 v8.0.0

Comments

@lukeelmers
Copy link
Member

Currently the esaggs expression function uses the remnants of what used to be called the "courier request handler", which handles calling SearchSource with the correct aggs.

At the moment it also does some magic like updating the inspector adapters with the request/response data, and also calls an agg postFlightRequest if one exists (for 'other' buckets on terms aggregations).

This means that folks using esaggs are getting the benefit of inspector integration & other bucket handling, but consumers of SearchSource are not. As esaggs is only meant to be an expression function that wraps SearchSource and returns tabified data, we should move this logic to SearchSource entirely:

  • Update search source to handle calling agg.postFlightRequest
  • Update search source to provide request/response data to the inspector adapters
  • Remove this logic from the esaggs request handler

For more context, see the comments on #83199

@lukeelmers lukeelmers added Feature:Search Querying infrastructure in Kibana Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) technical debt Improvement of the software architecture and operational architecture Team:AppArch labels Nov 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Search Querying infrastructure in Kibana technical debt Improvement of the software architecture and operational architecture v7.13.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Development

Successfully merging a pull request may close this issue.

3 participants