Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Do not persist default labels #84419

Open
flash1293 opened this issue Nov 26, 2020 · 1 comment
Open

[Lens] Do not persist default labels #84419

flash1293 opened this issue Nov 26, 2020 · 1 comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects

Comments

@flash1293
Copy link
Contributor

Right now we are creating a default label based on field and other information if a new column gets created.
This can cause consistency issues in some cases (like with custom field names #83512) and in general makes transition code more complex because for every transition the "label" prop has to be adjusted.

It's a larger refactoring because it touches a lot of places, but by not storing the default label anywhere and instead requiring code actually acting on the label to generate them using getDefaultLabel of the operation definition, we can reduce the bug surface, fix the consistency issues for custom field names defined on the index pattern and probably simplify the code a little as well.

To keep PRs manageable, I would like to keep this separate from the currently ongoing referencial operation work.

@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 26, 2020
@flash1293 flash1293 added this to Long-term goals in Lens via automation Nov 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Lens
  
Long-term goals
Development

No branches or pull requests

4 participants