Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana APM user capture setting #87659

Open
graphaelli opened this issue Jan 7, 2021 · 1 comment
Open

Kibana APM user capture setting #87659

graphaelli opened this issue Jan 7, 2021 · 1 comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed

Comments

@graphaelli
Copy link
Member

Describe the feature:

Add opt-in for capturing user data in Kibana's own APM. Other apm settings live under elastic.apm like elastic.apm.enabled. I propose elastic.apm.capture_user with a default of false.

Describe a specific use case for the feature:

User capture is filtered out unconditionally in:

kibana/src/apm.js

Lines 37 to 48 in 1d49166

// Filter out all user PII
apm.addFilter((payload) => {
try {
if (payload.context && payload.context.user && typeof payload.context.user === 'object') {
Object.keys(payload.context.user).forEach((key) => {
payload.context.user[key] = '[REDACTED]';
});
}
} finally {
return payload;
}
});

elastic/apm#272 proposes to add a setting for this. This request should not be blocked by that but could utilize the setting if the relevant changes land in the nodejs agent before this is picked up.

@graphaelli graphaelli added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov added enhancement New value added to drive a business result triage_needed labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed
Projects
None yet
Development

No branches or pull requests

3 participants