Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add telemetry plugins to the core eslint rules #88816

Closed
afharo opened this issue Jan 20, 2021 · 1 comment · Fixed by #93086
Closed

[chore] Add telemetry plugins to the core eslint rules #88816

afharo opened this issue Jan 20, 2021 · 1 comment · Fixed by #93086
Assignees
Labels
chore Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Jan 20, 2021

We should list all the telemetry-related plugins in

kibana/.eslintrc.js

Lines 1208 to 1220 in 170a295

files: [
// platform-team owned code
'src/core/**',
'x-pack/plugins/features/**',
'x-pack/plugins/licensing/**',
'x-pack/plugins/global_search/**',
'x-pack/plugins/cloud/**',
'packages/kbn-config-schema',
'src/plugins/status_page/**',
'src/plugins/saved_objects_management/**',
],
rules: {
'@typescript-eslint/prefer-ts-expect-error': 'error',

@afharo afharo added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry labels Jan 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Jan 20, 2021
@afharo afharo added this to In Progress in kibana-core [DEPRECATED] Mar 1, 2021
@afharo afharo moved this from In Progress to Pending Review in kibana-core [DEPRECATED] Mar 2, 2021
kibana-core [DEPRECATED] automation moved this from Pending Review to Done (7.12) Mar 2, 2021
@joshdover joshdover moved this from Done (7.12) to Done (7.13) in kibana-core [DEPRECATED] Mar 3, 2021
@joshdover joshdover moved this from Done (7.13) temp to Done (7.13) in kibana-core [DEPRECATED] Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Development

Successfully merging a pull request may close this issue.

2 participants