Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix buggy handling of user pressing delete on the field selector #89032

Closed
wylieconlon opened this issue Jan 21, 2021 · 1 comment · Fixed by #98588
Closed

[Lens] Fix buggy handling of user pressing delete on the field selector #89032

wylieconlon opened this issue Jan 21, 2021 · 1 comment · Fixed by #98588
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@wylieconlon
Copy link
Contributor

I expect that if you press delete on a field, that you would get an error message. But instead, we get an empty label:

Screen Shot 2021-01-21 at 4 40 51 PM

These are the steps needed to test this:

  1. Select Average of bytes or any other field
  2. Open the field selector, and press the Delete key
  3. Close the dimension without finishing your work

The correct behavior is already shown when dealing with reference-based operations like Moving Average. Steps to see the correct behavior:

  1. Drag Records into your workspace to get a date histogram chart
  2. Select the Y axis, and switch to Moving Average
  3. Open the field selector and press delete
  4. Error state is shown

Screen Shot 2021-01-21 at 4 46 20 PM

@wylieconlon wylieconlon added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jan 21, 2021
@wylieconlon wylieconlon added this to Long-term goals in Lens via automation Jan 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
3 participants