You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should be consistent in our use of native vs bluebird promises, as it can be confusing in the code to figure out which type is being used.
I'd like to propose that we add a style guide entry around this:
Use native promises where ever possible and reasonable
If you must use bluebird, and you are returning a Promise from an exported function, wrap it in a native promise. That way everyone can assume that a Promise returned from a function is of the native type.
Open for debate!
The text was updated successfully, but these errors were encountered:
A million times, yes. Using bluebird is an implementation detail of a module, it shouldn't be exported directly otherwise the API of the module is the API of bluebird.
I think we should be consistent in our use of native vs bluebird promises, as it can be confusing in the code to figure out which type is being used.
I'd like to propose that we add a style guide entry around this:
Open for debate!
The text was updated successfully, but these errors were encountered: