Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI] Rename AlertFlyout reloadAlerts method to onSave #91448

Closed
YulNaumenko opened this issue Feb 16, 2021 · 1 comment · Fixed by #91997
Closed

[Alerting UI] Rename AlertFlyout reloadAlerts method to onSave #91448

YulNaumenko opened this issue Feb 16, 2021 · 1 comment · Fixed by #91997
Assignees
@gmmorris
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
Kibana Alerting

Comments

@YulNaumenko
Copy link
Contributor

reloadAlerts is a confusing property name for a TriggersActionsUI AlertFlyout. It doesn't say what exactly it's doing - executing a callback method which happening on click Save button.
@YulNaumenko YulNaumenko added bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote added this to To-Do (Ordered by priority) in Kibana Alerting Feb 16, 2021
@gmmorris gmmorris moved this from To-Do (Ordered by priority) to In Progress in Kibana Alerting Feb 19, 2021
@gmmorris gmmorris self-assigned this Feb 19, 2021
@gmmorris gmmorris mentioned this issue Feb 19, 2021
Merged
3 tasks
@gmmorris gmmorris moved this from In Progress to In Review in Kibana Alerting Feb 19, 2021
Kibana Alerting automation moved this from In Review to Done (Ordered by most recent) Feb 23, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmmorris gmmorris

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Kibana Alerting
Done (Ordered by most recent)
Milestone
No milestone
4 participants
@gmmorris @kobelb @elasticmachine @YulNaumenko