Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Table] CSV Injection on Visualize module #91994

Closed
taha2009 opened this issue Feb 19, 2021 · 4 comments
Closed

[Data Table] CSV Injection on Visualize module #91994

taha2009 opened this issue Feb 19, 2021 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@taha2009
Copy link

Describe the bug:
It is found that visualization module is vulnerable to CSV Injection. The application have visualization module wherein the custom label field which then can be exported is vulnerable to CSV injection.

Kibana/Elasticsearch Stack version:
7.7

Server OS version:
Kubernetes 1.18

Browser and Browser OS versions: : Windows Chrome Version 88.0.4324.182

Elastic Endpoint version: 7.7

Original install method (e.g. download page, yum, from source, etc.): docker

Steps to reproduce:

1)Launch the log Analytics

2)Open Visualize> create visualization>Data table

1

2

3)Open data tab and add payload in custom label field-

Payload: =HYPERLINK("https://evillsitee.com","test")

3

4)Export the content and open the csv file

5)Formula payload injected will execute and will open the masked site.

4

Expected behavior:
Mitigation

To remediate it, ensure that no cells begin with any of the following characters:

Equals to (“=”)
Plus (“+”)
Minus (“-“)
At (“@”)
To mitigate, can add apostrophe (‘) in the beginning of the cell containing such characters. Adding apostrophe (‘) tells excel that the cell doesn’t contain formula and on viewing the MS.
Excel do not display apostrophe (‘) when entered as first character in the cell.

@taha2009 taha2009 added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. bug Fixes for quality problems that affect the customer experience labels Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong added Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! and removed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@spong spong changed the title [Security Solution] CSV Injection on Visualize module [Data Table] CSV Injection on Visualize module Feb 19, 2021
@timroes
Copy link
Contributor

timroes commented Feb 22, 2021

Duplicate of #56081

@timroes timroes marked this as a duplicate of #56081 Feb 22, 2021
@timroes timroes closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants