Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Migrate usages of AppMountParameters.onAppLeave to use ScopedHistory.block instead #92204

Open
flash1293 opened this issue Feb 22, 2021 · 1 comment
Open

[Lens] Migrate usages of AppMountParameters.onAppLeave to use ScopedHistory.block instead #92204

flash1293 opened this issue Feb 22, 2021 · 1 comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
Lens

Comments

@flash1293
Copy link
Contributor

Part of #92187

In kibana/x-pack/plugins/lens/public/app_plugin/app.tsx, onAppLeave is used - should be replaced by ScopedHistory.block
@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 22, 2021
@flash1293 flash1293 added this to Long-term goals in Lens via automation Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Feb 22, 2021
Closed
43 tasks
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Lens
  
Long-term goals
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flash1293 @elasticmachine @stratoula