Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Enforce use of import type and export type #93184

Closed
8 tasks done
afharo opened this issue Mar 2, 2021 · 3 comments · Fixed by #96199 or #96487
Closed
8 tasks done

[Telemetry] Enforce use of import type and export type #93184

afharo opened this issue Mar 2, 2021 · 3 comments · Fixed by #96199 or #96487
Labels
chore Feature:Telemetry good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Mar 2, 2021

Let's use import/export type where it applies. This is recommended for better bundle size, but also for not publicly exposing classes we don't want external services to use (but we still want to share their types).

  • packages/kbn-analytics/**
  • packages/kbn-telemetry-tools/**
  • src/plugins/kibana_usage_collection/**
  • src/plugins/usage_collection/**
  • src/plugins/telemetry/**
  • src/plugins/telemetry_collection_manager/**
  • src/plugins/telemetry_management_section/**
  • x-pack/plugins/telemetry_collection_xpack/**

We can do this as a follow-up to #92221

@afharo afharo added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo added this to Tech Debt Backlog in kibana-core [DEPRECATED] Mar 2, 2021
@afharo afharo added the technical debt Improvement of the software architecture and operational architecture label Mar 2, 2021
@afharo afharo added the good first issue low hanging fruit label Mar 9, 2021
@hardikpnsp
Copy link
Contributor

I would like to contribute to this. seems like I just have to compile the above modules with the --isolatedModuels flag and fix the Re-export errors.

@afharo afharo linked a pull request Apr 7, 2021 that will close this issue
1 task
kibana-core [DEPRECATED] automation moved this from Tech Debt Backlog to Done (7.13) Apr 7, 2021
@afharo
Copy link
Member Author

afharo commented Apr 7, 2021

Reopening because the changes were reverted on master.

@afharo afharo reopened this Apr 7, 2021
@afharo afharo linked a pull request Apr 8, 2021 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Telemetry good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
3 participants