Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Embeddable navigateToPrefilledEditor open in new tab #94555

Closed
shahzad31 opened this issue Mar 15, 2021 · 5 comments · Fixed by #96723
Closed

[Lens] Embeddable navigateToPrefilledEditor open in new tab #94555

shahzad31 opened this issue Mar 15, 2021 · 5 comments · Fixed by #96723
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@shahzad31
Copy link
Contributor

shahzad31 commented Mar 15, 2021

Describe the feature:

Lens provides navigateToPrefilledEditor for embeddable component, where user can navigate to view the visualisation in lens.

It works perfectly but it should also provide an option if user wants to open lens in new tabs. It can work as link or perhaps a prop to force it to open in a new tab.

@flash1293 flash1293 added this to Long-term goals in Lens via automation Mar 15, 2021
@flash1293 flash1293 added enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 changed the title Lens Embeddable navigateToPrefilledEditor open in new tab [Lens] Embeddable navigateToPrefilledEditor open in new tab Mar 15, 2021
@flash1293
Copy link
Contributor

@ThomThomson The Lens api uses this embeddable API under the hood:

It puts the params into session storage, then opens the Lens app which will read it from session storage again. This means it won't work out of the box for new tabs.

We could use local storage just for the transfer (put it there for the new tab navigation, in the new tab check local storage, move it to session storage and remove it from local storage again). What do you think?

@ThomThomson
Copy link
Contributor

@flash1293 that solution is definitely the one that comes to mind first, and it also seems like the right one in this circumstance. I will be very excited to see this API extended in this way!

@shahzad31
Copy link
Contributor Author

@ThomThomson is this something possible in near term?

@ThomThomson
Copy link
Contributor

@shahzad31, unfortunately I don't believe this is currently in our roadmap for the near term. Feel free to reach out on the kibana-presentation channel and we can talk about it a little more.

Lens automation moved this from Long-term goals to Done Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants