Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to unlink saved searches in vis editor #9484

Closed
ycombinator opened this issue Dec 14, 2016 · 5 comments
Closed

Unable to unlink saved searches in vis editor #9484

ycombinator opened this issue Dec 14, 2016 · 5 comments
Labels
discuss Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@ycombinator
Copy link
Contributor

Kibana version: master (at fa6d074).

Elasticsearch version: master (at elastic/elasticsearch@c8f241f)

Server OS version: Mac OS X 10.11.6 (El Capitan)

Browser version: Chrome 54.0.2840.98 (64-bit)

Browser OS version: Mac OS X 10.11.6 (El Capitan)

Original install method (e.g. download page, yum, from source, etc.): from source

Description of the problem including expected versus actual behavior:

I created a visualization from saved search. That worked as expected. Then I tried to unlink the saved search from the visualization. I expected the visualization to change but it didn't.

Looking at the request in the spy panel, it appears that the search query being sent to Elasticsearch is not updated once the saved search is unlinked. It continues to contain the query from the saved search.

Steps to reproduce:

  1. Create a saved search.
  2. Create a visualization from the saved search.
  3. Unlink the saved search from the visualization.

saved-search-no-unlinky

Errors in browser console (if relevant):
None.

Provide logs and/or server output (if relevant):
None.

@ycombinator ycombinator added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience P3 labels Dec 14, 2016
@ycombinator
Copy link
Contributor Author

Labeling as P3 as users could workaround this by not starting the visualization from the saved search. Feel free to change, @epixa @tbragin @ppisljar @thomasneirynck.

@ycombinator
Copy link
Contributor Author

ycombinator commented Dec 14, 2016

Actually, I'm not sure if this is a bug or expected behavior. When the saved search is unlinked, the filters from it are still shown (right below the search bar), which is consistent with the query shown in the spy panel.

I guess I expected all filters that were part of the saved search to go away as well, upon unlinking, but maybe that's not what other users expect. Relabeling as "discuss" for now.

@ycombinator ycombinator added discuss and removed bug Fixes for quality problems that affect the customer experience labels Dec 14, 2016
@epixa
Copy link
Contributor

epixa commented Dec 14, 2016

Unlinking should have no effect on the current search context, it should just unlink the current visualization from that saved search so that a user can start making changes to it.

@ycombinator
Copy link
Contributor Author

Thanks. In that case, this is all working as expected. Closing.

@tbragin
Copy link
Contributor

tbragin commented Dec 14, 2016

We are tracking a separate ER to change a saved search on an existing visualization: #5060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

No branches or pull requests

3 participants