Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Use expression builder for datasource and visualizations #94893

Closed
flash1293 opened this issue Mar 18, 2021 · 2 comments
Closed

[Lens] Use expression builder for datasource and visualizations #94893

flash1293 opened this issue Mar 18, 2021 · 2 comments
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
Lens

Comments

@flash1293
Copy link
Contributor

In the expression builder functions for all Lens visualizations and datasource, the return object is only typed as Ast. This is a gap in type checking (all other layers of Lens use specific types) and could lead to bugs.

Like for the esaggs expression building, the buildExpressionFunction helper should be used to make sure the right ast is built
@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 18, 2021
@flash1293 flash1293 added this to Long-term goals in Lens via automation Mar 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Mar 18, 2021
Closed
43 tasks
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Feb 15, 2023
@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@stratoula stratoula closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Lens
  
Long-term goals
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flash1293 @elasticmachine @stratoula