Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Instances plot: The click area of the selectable dots are not accessible when they're on the outer areas of the chart canvas #97101

Open
formgeist opened this issue Apr 14, 2021 · 6 comments
Labels
apm:ux blocked bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.0.0

Comments

@formgeist
Copy link
Contributor

Kibana version: master

Summary

After some more testing on the new instances scatter plot, I've noticed that the click access on the chart isn't always great, especially when the dots are in outer areas of the chart canvas. Not sure if this is a limitation of the chart itself, or our implementation. One way to possibly mitigate this is to extend the domains.

2021-04-14 at 14 09 05 - Violet Worm

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.0.0 labels Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor

smith commented Apr 14, 2021

This might be fixable by adding a little padding to the chart theme on this chart. That might be simpler than messing with the domain, but we can also do that if the first thing doesn't work.

@formgeist
Copy link
Contributor Author

@smith sounds reasonable, probably don't need much tbh

@sorenlouv sorenlouv added [zube]: 7.13 low hanging fruit DO NOT USE. Use `good first issue` instead labels Apr 14, 2021
@smith smith removed the low hanging fruit DO NOT USE. Use `good first issue` instead label Apr 26, 2021
@smith smith self-assigned this Apr 26, 2021
@smith
Copy link
Contributor

smith commented Apr 27, 2021

I wrote:

This might be fixable by adding a little padding to the chart theme on this chart. That might be simpler than messing with the domain, but we can also do that if the first thing doesn't work.

I asked in Slack and @nickofthyme answered:

Yeah that’s the corner of the canvas so any pointer position off the canvas element itself will not show the points. We should make an issue to make this better.

The Theme.chartPadding is only going to reduce the area of the canvas relative to the axis, not provide a buffer to trigger point events. See this example
https://codesandbox.io/s/quizzical-hill-4gclw?file=/src/App.tsx

But a solution that might achieve what you are looking for as a terrible workaround, would be to add a buffer to the domain. This would require you to compute the domain thus not ideal.

I would suggest opening a new issue on our repo.

Opened elastic/elastic-charts#1140

@botelastic
Copy link

botelastic bot commented Feb 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Feb 9, 2022
@nickofthyme
Copy link
Contributor

nickofthyme commented Feb 9, 2022

Issue is open in charts elastic/elastic-charts#1140. I added it to our project backlog, awaiting priority.

@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ux blocked bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.0.0
Projects
None yet
Development

No branches or pull requests

6 participants