Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove license checks from ES UI Basic-licensed plugins #97314

Open
2 of 7 tasks
cjcenizal opened this issue Apr 15, 2021 · 2 comments
Open
2 of 7 tasks

Remove license checks from ES UI Basic-licensed plugins #97314

cjcenizal opened this issue Apr 15, 2021 · 2 comments
Labels
chore Feature:License Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Apr 15, 2021

Per #95973 (review), many of ES UI's Basic-licensed apps implement an unnecessary server-side license check. See for example: Ingest Node Pipelines, Index Management and ILM). We can remove these since Basic-licensed apps will be unrestricted under any license.

@cjcenizal cjcenizal added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Apr 15, 2021

I'm working through ILM and I just found out that it does its own fetching of snapshot policies and snapshot repositories, which are available under the Enterprise license. These entities are used to power the searchable snapshots and "Wait for snapshot before deleting" functionality, respectively.

I wonder if we should create an optional dependency upon the Snapshot and Restore plugin and use its APIs to fetch these entities instead?

Pros Cons
Single source of truth for fetching SR entities Theoretically, a user might disable the SR plugin in Kibana without disabling it in ES, creating a false dependency
Reduced code
We can disable the relevant UI if the plugin is disabled

This boils down to the essential question: is it fair and realistic to assume the ES SR functionality is available if the Snapshot and Restore plugin is enabled? FWIW, this plugin is enabled in Cloud, despite Cloud having its own backups UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:License Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants