Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Paging through records with mouse or keyboard should update flyout contents #99115

Closed
Tracked by #166238
shaunmcgough opened this issue May 3, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@shaunmcgough
Copy link

When the new data grid is enabled, if you click on a row or arrow through the rows of records, it should update the display of the flyout to reflect the record you've clicked on (regardless of the field you clicked), and also highlight that row in yellow (as it does when you click the expand arrows.

Screen Shot 2021-05-03 at 3 50 16 PM

@shaunmcgough shaunmcgough added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented May 4, 2021

I have some a11y concerns around this. In my opinion a behavior like this will break hardly on WCAG 3.2.1 since we're changing context in a non focused part of the UI, by pure focus changes in another part of the UI. cc @myasonik I would like to get your opinion on this suggestion before we consider this.

@myasonik
Copy link
Contributor

myasonik commented May 4, 2021

It would take some careful work but there are certainly ways we could do this.

WCAG 3.2.1 is pretty easy to avoid running into issues on by not moving focus to the flyout whenever the row changes.

But to do that, we need to have an aria-live region that will announce to screen readers that another part of the page has changed.

To visually better support this split panel design, you might also want to consider the upcoming push flyout style to actually have the table and flyout side-by-side rather than a flyout over the table that you're also supposed to be interacting with.

@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member

kertal commented Jan 24, 2023

Requirement for this, using the push flyout #148902

@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Jan 24, 2023
@kertal kertal added the Icebox label Nov 6, 2023
@kertal
Copy link
Member

kertal commented Nov 6, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

5 participants