Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Manager is too optimisitic about dependencies when installing unrelated plugins #13789

Closed
yaauie opened this issue Feb 17, 2022 · 0 comments · Fixed by #13794
Closed
Assignees
Labels

Comments

@yaauie
Copy link
Member

yaauie commented Feb 17, 2022

When using the plugin manager to install a plugin, even a plugin that is already installed, the plugin manager updates the graph to pull in updates to unrelated dependencies.

This recently lead to our users consuming Sinatra 2.2.0 on its release day (#13777), despite it introducing a JRuby-specific bug, because our dependency was merely listed as ~>2.

We should investigate if we can cause bundler to update transitive dependencies of Logstash if and only if they are also dependencies of the new plugins being installed or updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants