Logstash - Plugins - SSL Settings Standardization - Standardize HTTP INPUT settings

[edmocosta]

This issue should make the plugin SSL settings consistent with the naming convention defined in the meta issue. Missing settings already supported by the plugin's HTTP/TCP client, which only requires small coding changes on the plugin source, should also be added through this issue.

Add and deprecate options to comply with the naming convention

• ssl -> ssl_enabled
• ssl_verify_mode -> ssl_verification_mode
• keystore -> ssl_keystore_path
• keystore_password -> ssl_keystore_password

Verify deprecated Java store files settings, should they really be deprecated?

• keystore
• keystore_password

Verify matching settings types, allowed values, defaults

• ssl_certificate
• ssl_certificate_authorities
• ssl_cipher_suites
• ssl_handshake_timeout
• ssl_key
• ssl_key_passphrase
• ssl_supported_protocols

Add common settings validations

• Not allow mixing the same deprecated and new setting on the same plugin configuration, e.g. ssl and ssl_enabled

Add ssl_verification_mode functionality and mark ssl_certificate_verification as deprecated

• Values don't match, make it in a backward-compatible way

Add missing settings/functionality that fits into the phase 1 description, and move non-phase 1-2 to the phase 3 issue (to be created if doesn't exist)

• ssl_client_authentication
• ssl_keystore_type
• ssl_keystore_key_password
• ssl_truststore_path
• ssl_truststore_password
• ssl_truststore_type