Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grok Pattern in file, should trim ending spaces #1843

Closed
woodyyou opened this issue Oct 3, 2014 · 3 comments
Closed

grok Pattern in file, should trim ending spaces #1843

woodyyou opened this issue Oct 3, 2014 · 3 comments
Assignees

Comments

@woodyyou
Copy link

woodyyou commented Oct 3, 2014

I put grok patterns in a file, didn't realized there was a space at the end. It resulted not match. Took me quite some time to figure out that's the problem (need to use rubydebug to tell there's a parsing error, even -v didn't tell).

Since leading spaces do not matter, ending space should not either. Also, I think it's a common mistake.

@jordansissel
Copy link
Contributor

Fair point. +1.

Related, could be lovely if Grok would offer a nicer way to automate debugging of where in a pattern it didn't match.

@ph ph self-assigned this Oct 6, 2014
@suyograo suyograo added this to the v1.5.0 milestone Jan 22, 2015
@suyograo suyograo added the bug label Jan 22, 2015
@suyograo suyograo assigned talevy and unassigned ph Jan 22, 2015
@talevy
Copy link
Contributor

talevy commented Jan 22, 2015

PR for rejecting patterns with trailing whitespaces: jordansissel/ruby-grok#15

@suyograo suyograo modified the milestones: 2.0, v1.5.0 Feb 3, 2015
@jordansissel
Copy link
Contributor

For Logstash 1.5.0, we've moved all plugins to individual repositories, so I have moved this issue to logstash-plugins/logstash-filter-grok#36. Let's continue the discussion there! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants