Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows test results #2487

Closed
jordansissel opened this issue Jan 30, 2015 · 8 comments
Closed

Windows test results #2487

jordansissel opened this issue Jan 30, 2015 · 8 comments
Assignees
Labels

Comments

@jordansissel
Copy link
Contributor

@ph and I are working on fixing logstash bugs on Windows in the wip/bundler-move branch (Confusingly name, I know. It's a mix of work in there)

I had to disable some plugins because they were causing rspec to crash (not a test failure, rspec would raise exception and abort execution)

#gem 'logstash-input-file'
#gem 'logstash-input-generator'
#gem 'logstash-input-pipe'
#gem 'logstash-input-syslog'
#gem 'logstash-input-tcp'
#gem 'logstash-output-statsd'

The full test output is here: https://gist.github.com/jordansissel/622db419dc1b284794bd

I will file bugs on individual repos as a result, but this ticket tracks the study.

@jordansissel
Copy link
Contributor Author

We can ignore any tests that failed because the generator input was missing: (output csv, etc), the error looks like this:

LogStash::PluginLoadingError:
       Couldn't find any input plugin named 'generator'.

Plugin test suites affected by this:

  • rabbitmq output
  • csv output
  • date filter

@ph
Copy link
Contributor

ph commented Feb 3, 2015

one more test failing in the S3 output look related to the generator input.

@jordansissel
Copy link
Contributor Author

@ph can you link to the issue here?

@jsvd
Copy link
Member

jsvd commented Feb 4, 2015

I proposed a fix for encoding issues in #2507
Since there are other vectors besides Socket.gethostname, neither monkey patching Socket or wrapping the call in Logstash::Util is enough.

@ph ph added the windows label Feb 4, 2015
@ph
Copy link
Contributor

ph commented Feb 4, 2015

We will need to merge #2507 or find a better fix for windows and rerun the tests with the latest changes.

@ph
Copy link
Contributor

ph commented Feb 20, 2015

Second run of test in https://gist.github.com/ph/1d83c833d89b7c1de9b4

@jsvd
Copy link
Member

jsvd commented Feb 20, 2015

My latest results with the bundler-move branch:

Using the following as "rake test:plugins2":

task "plugins" do
  gem_root = File.expand_path('./vendor/bundle/jruby/1.9/')
  pattern = File.join(*"gems/logstash-*/spec/{input,filter,codec,output}s/*_spec.rb".split("/"))
  sh "#{LogStash::Environment::LOGSTASH_HOME}/bin/logstash rspec --format documentation --order rand #{gem_root} -P '#{pattern}'"
end

rake test:plugins => 30 failures
rake test:plugins2 => 11 failures

Results: https://gist.github.com/jsvd/f6ab54b5b4c8ed9537a8

@ph
Copy link
Contributor

ph commented Apr 13, 2015

Closing this since all the related tickets were closed, will open a new one if needed.

@ph ph closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants