Why do we include maven-home jars?

[suyograo]

The LS release artifacts have these jars..What are these used for?

./vendor/jruby/lib/ruby/maven-home/boot/plexus-classworlds-2.5.2.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-api-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-connector-basic-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-impl-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-spi-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-transport-wagon-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aether-util-1.0.2.v20150114.jar
./vendor/jruby/lib/ruby/maven-home/lib/aopalliance-1.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/cdi-api-1.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/commons-cli-1.2.jar
./vendor/jruby/lib/ruby/maven-home/lib/commons-io-2.2.jar
./vendor/jruby/lib/ruby/maven-home/lib/commons-lang-2.6.jar
./vendor/jruby/lib/ruby/maven-home/lib/guava-18.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/javax.inject-1.jar
./vendor/jruby/lib/ruby/maven-home/lib/jsoup-1.7.2.jar
./vendor/jruby/lib/ruby/maven-home/lib/jsr250-api-1.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-aether-provider-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-artifact-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-builder-support-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-compat-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-core-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-embedder-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-model-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-model-builder-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-plugin-api-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-repository-metadata-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-settings-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/maven-settings-builder-3.3.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/org.eclipse.sisu.inject-0.3.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/org.eclipse.sisu.plexus-0.3.0.jar
./vendor/jruby/lib/ruby/maven-home/lib/plexus-cipher-1.7.jar
./vendor/jruby/lib/ruby/maven-home/lib/plexus-component-annotations-1.5.5.jar
./vendor/jruby/lib/ruby/maven-home/lib/plexus-interpolation-1.21.jar
./vendor/jruby/lib/ruby/maven-home/lib/plexus-sec-dispatcher-1.3.jar
./vendor/jruby/lib/ruby/maven-home/lib/plexus-utils-3.0.20.jar
./vendor/jruby/lib/ruby/maven-home/lib/sisu-guice-3.2.5-no_aop.jar
./vendor/jruby/lib/ruby/maven-home/lib/slf4j-api-1.7.5.jar
./vendor/jruby/lib/ruby/maven-home/lib/slf4j-simple-1.7.5.jar
./vendor/jruby/lib/ruby/maven-home/lib/wagon-file-2.9.jar
./vendor/jruby/lib/ruby/maven-home/lib/wagon-http-2.9-shaded.jar
./vendor/jruby/lib/ruby/maven-home/lib/wagon-http-shared-2.9.jar
./vendor/jruby/lib/ruby/maven-home/lib/wagon-provider-api-2.9.jar

[suyograo]

@purbon any idea?

[purbon]

@suyograo not really, let me investigate and I'm back to you. My first thought this is because of ruby-maven and jar-dependency being now part of jruby.

more info here, this jars are part of ruby-maven-libs, the ruby-maven distribution as you can see:

purbon-elastic% grep -rn maven-home jruby 
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-libs-3.3.3.gemspec:14:  s.extra_rdoc_files = ["maven-home/README.txt", "maven-home/NOTICE", "maven-home/LICENSE", "README.md"]
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-libs-3.3.3.gemspec:15:  s.files = ["README.md", "lib/maven.rb", "maven-home/LICENSE", "maven-home/NOTICE", "maven-home/README.txt", "maven-home/bin/m2.conf", "maven-home/bin/mvn", "maven-home/bin/mvn.cmd", "maven-home/bin/mvnDebug", "maven-home/bin/mvnDebug.cmd", "maven-home/bin/mvnyjp", "maven-home/boot/plexus-classworlds-2.5.2.jar", "maven-home/conf/logging/simplelogger.properties", "maven-home/conf/settings.xml", "maven-home/conf/toolchains.xml", "maven-home/lib/aether-api-1.0.2.v20150114.jar", "maven-home/lib/aether-api.license", "maven-home/lib/aether-connector-basic-1.0.2.v20150114.jar", "maven-home/lib/aether-connector-basic.license", "maven-home/lib/aether-impl-1.0.2.v20150114.jar", "maven-home/lib/aether-impl.license", "maven-home/lib/aether-spi-1.0.2.v20150114.jar", "maven-home/lib/aether-spi.license", "maven-home/lib/aether-transport-wagon-1.0.2.v20150114.jar", "maven-home/lib/aether-transport-wagon.license", "maven-home/lib/aether-util-1.0.2.v20150114.jar", "maven-home/lib/aether-util.license", "maven-home/lib/aopalliance-1.0.jar", "maven-home/lib/cdi-api-1.0.jar", "maven-home/lib/cdi-api.license", "maven-home/lib/commons-cli-1.2.jar", "maven-home/lib/commons-io-2.2.jar", "maven-home/lib/commons-lang-2.6.jar", "maven-home/lib/ext/README.txt", "maven-home/lib/guava-18.0.jar", "maven-home/lib/javax.inject-1.jar", "maven-home/lib/jsoup-1.7.2.jar", "maven-home/lib/jsoup.license", "maven-home/lib/jsr250-api-1.0.jar", "maven-home/lib/jsr250-api.license", "maven-home/lib/maven-aether-provider-3.3.3.jar", "maven-home/lib/maven-aether-provider.license", "maven-home/lib/maven-artifact-3.3.3.jar", "maven-home/lib/maven-artifact.license", "maven-home/lib/maven-builder-support-3.3.3.jar", "maven-home/lib/maven-builder-support.license", "maven-home/lib/maven-compat-3.3.3.jar", "maven-home/lib/maven-compat.license", "maven-home/lib/maven-core-3.3.3.jar", "maven-home/lib/maven-core.license", "maven-home/lib/maven-embedder-3.3.3.jar", "maven-home/lib/maven-embedder.license", "maven-home/lib/maven-model-3.3.3.jar", "maven-home/lib/maven-model-builder-3.3.3.jar", "maven-home/lib/maven-model-builder.license", "maven-home/lib/maven-model.license", "maven-home/lib/maven-plugin-api-3.3.3.jar", "maven-home/lib/maven-plugin-api.license", "maven-home/lib/maven-repository-metadata-3.3.3.jar", "maven-home/lib/maven-repository-metadata.license", "maven-home/lib/maven-settings-3.3.3.jar", "maven-home/lib/maven-settings-builder-3.3.3.jar", "maven-home/lib/maven-settings-builder.license", "maven-home/lib/maven-settings.license", "maven-home/lib/org.eclipse.sisu.inject-0.3.0.jar", "maven-home/lib/org.eclipse.sisu.inject.license", "maven-home/lib/org.eclipse.sisu.plexus-0.3.0.jar", "maven-home/lib/org.eclipse.sisu.plexus.license", "maven-home/lib/plexus-cipher-1.7.jar", "maven-home/lib/plexus-cipher.license", "maven-home/lib/plexus-component-annotations-1.5.5.jar", "maven-home/lib/plexus-interpolation-1.21.jar", "maven-home/lib/plexus-sec-dispatcher-1.3.jar", "maven-home/lib/plexus-sec-dispatcher.license", "maven-home/lib/plexus-utils-3.0.20.jar", "maven-home/lib/sisu-guice-3.2.5-no_aop.jar", "maven-home/lib/slf4j-api-1.7.5.jar", "maven-home/lib/slf4j-api.license", "maven-home/lib/slf4j-simple-1.7.5.jar", "maven-home/lib/slf4j-simple.license", "maven-home/lib/wagon-file-2.9.jar", "maven-home/lib/wagon-file.license", "maven-home/lib/wagon-http-2.9-shaded.jar", "maven-home/lib/wagon-http-shared-2.9.jar", "maven-home/lib/wagon-http-shared.license", "maven-home/lib/wagon-http.license", "maven-home/lib/wagon-provider-api-2.9.jar", "maven-home/lib/wagon-provider-api.license"]
jruby/lib/ruby/shared/maven.rb:15:                File.expand_path( "#{dir}/../maven-home" )

and as you can see, this is only used inside jruby for jar-dependencies and ruby-maven.

purbon-elastic% grep -rn ruby-maven-lib jruby 
jruby/lib/ruby/gems/shared/specifications/default/jar-dependencies-0.1.15.gemspec:27:      s.add_development_dependency(%q<ruby-maven-libs>, ["~> 3.3.0"])
jruby/lib/ruby/gems/shared/specifications/default/jar-dependencies-0.1.15.gemspec:32:      s.add_dependency(%q<ruby-maven-libs>, ["~> 3.3.0"])
jruby/lib/ruby/gems/shared/specifications/default/jar-dependencies-0.1.15.gemspec:38:    s.add_dependency(%q<ruby-maven-libs>, ["~> 3.3.0"])
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-3.3.3.gemspec:26:      s.add_runtime_dependency(%q<ruby-maven-libs>, ["~> 3.3.1"])
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-3.3.3.gemspec:30:      s.add_dependency(%q<ruby-maven-libs>, ["~> 3.3.1"])
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-3.3.3.gemspec:35:    s.add_dependency(%q<ruby-maven-libs>, ["~> 3.3.1"])
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-libs-3.3.3.gemspec:2:# stub: ruby-maven-libs 3.3.3 ruby lib
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-libs-3.3.3.gemspec:5:  s.name = "ruby-maven-libs"
jruby/lib/ruby/gems/shared/specifications/default/ruby-maven-libs-3.3.3.gemspec:16:  s.homepage = "https://github.com/takari/ruby-maven-libs"
jruby/lib/ruby/shared/jars/maven_exec.rb:116:      add_gem_to_load_path( 'ruby-maven-libs' )

as we're not relaying in jar-dependencies I would say we can try to remove them and slim down the distribution 👍

[purbon]

See #3855 for a PR that gets this out as they are not anymore necessary. Not much win, but some unused MB out for sure.

[suyograo]

from @purbon: this will get fixed upstream in JRuby distro. See discussion #3855 (comment)