PERFORMANCE: Flatten logic for write batch instantiation #8163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
force-pushed
the
simplify-write-batch-generation
branch
from
a4b8491
to
2517f5b
Compare
|
@guyboertje can you review? My thoughts are that this goes backwards with respect to some anticipated-future-work where we have a firmer API around batches. |
|
It does look like it removes some anticipated work. I am satisfied that, when the future arrives, we will do a better job in Java for the Queue clients and Batches. |
|
@guyboertje thanks ! :) |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8155:
The
get_new_batchmethods on the memory and the acked queue are both internal APIs and completely redundant since plugins only seeWrappedWriteClient.=> flattened this out
Also ... this actually comes with a measurable, statistically significant gain of
~3%on the baseline (likely removing one step of stack depth got us over the barrier to not be affected by jruby/jruby#4763 forRubyArrayhere).