Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new type of validation for defining a pipeline_id #8164

Open
ph opened this issue Sep 7, 2017 · 1 comment
Open

Add a new type of validation for defining a pipeline_id #8164

ph opened this issue Sep 7, 2017 · 1 comment

Comments

@ph
Copy link
Contributor

ph commented Sep 7, 2017

The current validation when defining a pipeline_id is really minimal, I should say non-existent, we accept everything that can be coerced to a string. This means the following string identifier are valid pipeline_id.

  • 1
  • 2pipeline
  • 3pipeline####!
  • 😴🙄🤔🤥
  • hola (space at the end of a string)

I think we should do the following:

  • Limit the possible charsets to lowercase a-z, hyphens, numbers.
  • Create a concrete type that the Java code and the settings validator can use.
  • Refactor the config management to use that type
  • strip whitespace at the end and beginning.
  • Derive an Array type from the concrete type, (id must be unique)
  • Maybe accept any characters that a uuid v3 can accept? This will make it more compatible with GUI tools.
@jsvd
Copy link
Member

jsvd commented Sep 20, 2017

an interesting issue on this kind of problem from elasticsearch: elastic/elasticsearch#9059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants