Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RUM integration #21

Open
felixbarny opened this issue Nov 6, 2018 · 4 comments
Open

Enable RUM integration #21

felixbarny opened this issue Nov 6, 2018 · 4 comments

Comments

@felixbarny
Copy link
Member

Use the new API methods to enable RUM correlation: https://www.elastic.co/guide/en/apm/agent/java/master/public-api.html#api-ensure-parent-id

The difficulty is that Opbeans should probably still work with older versions. So the version of the API has to be fixed to 1.0.0.RC1 or 1.0.0, when it's released. The API is backwards compatible so it is possible to use older agents with the new API.

@felixbarny
Copy link
Member Author

I’m not sure the RUM/backend correlation will be possible in our current opbeans setup. The frontend, including the index.html is served statically so we can’t correlate that with the backend trace as there is none.

The RUM agent calls /rum-config.js but that would create a backend transaction which is unrelated to the actual pageload. Also, *.js files are excluded from tracing in Java agent by default.

@felixbarny felixbarny added the wontfix This will not be worked on label Nov 6, 2018
@felixbarny
Copy link
Member Author

closing as won't fix for now

//cc @roncohen @alvarolobato

@roncohen
Copy link

roncohen commented Nov 6, 2018

could you add a new endpoint that would serve from HTML (for example the same index.html) but also create some spans before responding? This wouldn't be a great example initially, but would get us started

@felixbarny felixbarny removed the wontfix This will not be worked on label Nov 12, 2018
@roncohen
Copy link

would be great to have this as a way to demonstrate that RUM integration actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants