Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test with Ingest Manager #462

Closed
ruflin opened this issue May 14, 2020 · 5 comments
Closed

Add integration test with Ingest Manager #462

ruflin opened this issue May 14, 2020 · 5 comments
Labels
Ingest Management:beta1 Group issues for ingest management beta1

Comments

@ruflin
Copy link
Member

ruflin commented May 14, 2020

Any change in the package registry can effect the Ingest Manager in Kibana. Because of this normally when I do changes on the package registry I spin up Kibana, run the /setup step of the Ingest Manager and run an agent to ingest some basic data to see if any errors are triggered. It would be great to automate this and have it as part of the CI.

@ruflin
Copy link
Member Author

ruflin commented May 25, 2020

The way I do this locally currently is:

cd testing/environments
docker-compose -f snapshot.yml -f local.yml up --force-recreate
# Wait until all containers are healthy
curl -X POST http://elastic:changeme@localhost:5601/api/ingest_manager/setup -H "kbn-xsrf: ingest_manager"
# Make sure not errors are returned

This at least tests if the basic setup still works (without agent).

@mtojek WDYT about adding something like above as an additional test command?

@mtojek
Copy link
Contributor

mtojek commented May 25, 2020

Hmm.. actually I was planning to remove the "testing/environment" from this repo and only use the one defined in integrations. We need tools for this too :)

As long as we don't have tools, we can either checkout testing/environment from "integrations" or continue working on the copy here.

@ruflin
Copy link
Member Author

ruflin commented May 26, 2020

I think we need to have it in both places as they have a bit different purposes, even though the code at the moment will be identical. This one here is to test, if package-registry changes work with the ingest manager. The one in the integrations repo is to test the packages itself.

I don't think we package-registry should have a dependency on the integrations repo.

@mtojek
Copy link
Contributor

mtojek commented May 26, 2020

I don't think we package-registry should have a dependency on the integrations repo.

Neither do I. In the future it can use the "tools".

Also, I believe the docker-compose.yml file in this repository needs an update.

@ph ph added the Ingest Management:beta1 Group issues for ingest management beta1 label Jun 1, 2020
@ruflin
Copy link
Member Author

ruflin commented Jun 22, 2020

Closing as some basic integration tests with Kibana have been added. Future refactoring need.

@ruflin ruflin closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Development

No branches or pull requests

3 participants