Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding enabled/retestOnFailure via global config #896

Merged
merged 1 commit into from Feb 21, 2024

Conversation

vigneshshanmugam
Copy link
Member

  • fix Global monitor options enabled and retestOnFailure are ignored #894
  • enabled: false and retestOnFailure: false on the synthetics global config did not get passed to Kibana which effectively meant the users can only enable/disable them via individual monitor config. This PR fixes the problem and allows all monitors to be overridden with correct value.

Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--

Tested with this global monitor settings:

    // ...
    /**
     * Configure global monitor settings
     */
    monitor: {
      schedule: 5,
      locations: ['local_synthetics_service'] as any,
      privateLocations: [],
      tags: ['']
      enabled: false,
      throttling: false,
      retestOnFailure: false,
    },

   // ...

before the change:

Screenshot before the change

after the change:

Screenshot after the change

@vigneshshanmugam vigneshshanmugam merged commit 27182c6 into elastic:main Feb 21, 2024
7 checks passed
@vigneshshanmugam vigneshshanmugam deleted the fix-global-opts branch February 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global monitor options enabled and retestOnFailure are ignored
2 participants