fix: redact sensitive req/response headers by default #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vigneshshanmugam
commented
Mar 19, 2024
•
vigneshshanmugam
commented
- fix Support suppressing of sensitive parameters / URLs #468
- Redacts some of the well known sensitive headers and other Access token related keys that might be accidentally captured by the agent when capturing network information.
- Cookies are already filtered out by Playwright, But we still get rid of Cookie and Set cookie for the request/response cycle to be on safer side.
|
LGTM 🎉 , just added a question Testing went well: before the PR changes screenshot
after the PR changes screenshot
|
devcorpio
reviewed
Mar 20, 2024
| * https://github.com/elastic/apm/blob/36a5abd49ff156c80cf0c9e2e1eac919873cb18b/specs/agents/sanitization.md?plain=1#L27 | ||
| */ | ||
| const SANITIZE_HEADER_KEYS = [ | ||
| /^password$/i, |
There was a problem hiding this comment.
[question]
Is there any reason for not adding all the "default" keys available in the APM document?
There was a problem hiding this comment.
Mainly because it was an exhaustive set of list and we can introduce these extra headers like credit, card etc incase its required. Also frontend headers differ a lot between the backend transactions which might involve order processing system and other services which makes sense for backend agents.
devcorpio
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.