ec_deployments: Bugfix for queries with hyphens #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge as the tests I was fixing passed
|
6 tasks
marclop
pushed a commit
that referenced
this pull request
Feb 18, 2021
…ts (#242) This PR is a follow up to the bug discovered in #241 The deployment read API returns all possible topology elements even if the size is set to 0. This means that the ec_deployment datasource will return more topology elements than what is set in the ec_deployment resource. This patch makes sure only the topology elements used in the deployment are returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the name prefix query was using a text field rather
than a keyword field in order to ensure the query is not analyzed.
Additionally the acceptance tests have been fixed since recently it
appears the deployment read API returns all possible topology elements
even if the size is set to 0. This means that the
ec_deploymentdatasourcewill return more topology elements than what is set in the
ec_deploymentresource. I will open up a follow up PR with the fix for this, but I wanted to
leave the tests passing for now.
Related Issues
Closes: #239
How Has This Been Tested?
Manually and through acceptance tests
Types of Changes
Readiness Checklist