Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds/ec_deployments: Add name and alias fields #362

Merged
merged 2 commits into from
Sep 1, 2021
Merged

ds/ec_deployments: Add name and alias fields #362

merged 2 commits into from
Sep 1, 2021

Conversation

marclop
Copy link
Contributor

@marclop marclop commented Aug 31, 2021

Description

Adds two new fields, deployments.#.name and deployments.#.alias to
the ec_deployments datasource.

Related Issues

Part of #357

How Has This Been Tested?

Unit and Acceptance tested.

Types of Changes

  • New feature (non-breaking change which adds functionality)

@marclop
ds/ec_deployments: Add name and alias fields
1c8a732 
Adds two new fields, `deployments.#.name` and `deployments.#.alias` to
the `ec_deployments` datasource.

Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
@marclop marclop added enhancement New feature or request Team:Delivery labels Aug 31, 2021
@marclop marclop self-assigned this Aug 31, 2021
@marclop marclop requested review from alaudazzi, nrichers and a team as code owners August 31, 2021 14:50
@marclop
Update changelog
59c54c5 
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
@marclop
Copy link
Contributor Author

marclop commented Sep 1, 2021

Acceptance failure is transient:

17:40:30  === CONT  TestAccDeployment_basic_defaults_hw
17:40:30      testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
17:40:30          
17:40:30          Error: found deployment plan errors: 1 error occurred:
17:40:30          	* deployment [89483d3634e21edec0842c12c8462a40] - [elasticsearch][44aadf6efd92422d925c5d6e72f5607e]: caught error: "Plan change failed: Could not delete the instance. Please check the allocator and instance logs, and then retry."
17:40:30          
17:40:30          
17:40:30          
17:40:30  --- FAIL: TestAccDeployment_basic_defaults_hw (1616.45s)

@marclop marclop merged commit 11457cc into elastic:master Sep 1, 2021
@marclop marclop deleted the b/add-name-alias-to-ec_deployments-resource branch September 1, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpar-t alpar-t alpar-t approved these changes

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

@nrichers nrichers Awaiting requested review from nrichers

Assignees

@marclop marclop

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marclop @alpar-t