Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfaults during Create/Update for ec_deployment. #719

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented Sep 29, 2023

Fix segfaults during Create/Update for ec_deployment

  • when elasticsearch attribute contains both strategy and snapshot_source;
  • when elasticsearch defines snapshot with repository that doesn't contain reference.

Description

Related Issues

Closes: #715

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dimuon dimuon requested a review from a team as a code owner September 29, 2023 12:03
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested my reproduction scenario mentioned in #715 with this change and it works fine now. Thanks for the super quick fix!

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimuon dimuon enabled auto-merge (squash) October 2, 2023 10:22
- when `elasticsearch` attribute contains both `strategy` and `snapshot_source`;
- when `elasticsearch` defines `snapshot` with `repository` that doesn't contain `reference`.
@dimuon dimuon merged commit 3b20307 into elastic:master Oct 2, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC provider v0.9.0 segfaults while modifying ec_deployment resource
3 participants